Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ecs & phpstan code analysis #23

Open
wants to merge 3 commits into
base: v3-dev
Choose a base branch
from
Open

feat: add ecs & phpstan code analysis #23

wants to merge 3 commits into from

Conversation

khalwat
Copy link
Contributor

@khalwat khalwat commented Mar 12, 2024 •
edited
Loading

Add ecs & phpstan code analysis

I also ran both ecs and phpstan, which cleaned up the code, and I manually fixed one error phpstan pointed out.

You can manually run either ecs or phpstan in local dev, and they will also automatically be run:

  • Whenever you push to the v3-dev branch
  • Whenever someone else does a PR

When someone does a PR, it'll look like this for them:

Screenshot 2024-03-11 at 10 30 55 PM

...and then once it has passed (or failed) it'll look like this:

Screenshot 2024-03-11 at 10 31 25 PM

@khalwat
Copy link
Contributor Author

khalwat commented Mar 12, 2024

I did this only for the Craft 5 version of the plugin. If you want to backport it to Craft 4, it's the exact same everything for Craft 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@khalwat